Add comments about removing artifact-legacy once supported on GHES

github · Sep 13, 2024 · 3641023 · 3641023
1 parent 67ed331
commit 3641023
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 2 deletions.
diff --git a/lib/debug-artifacts.js b/lib/debug-artifacts.js
diff --git a/lib/debug-artifacts.js.map b/lib/debug-artifacts.js.map
diff --git a/lib/start-proxy-action-post.js b/lib/start-proxy-action-post.js
diff --git a/lib/start-proxy-action-post.js.map b/lib/start-proxy-action-post.js.map
diff --git a/src/debug-artifacts.ts b/src/debug-artifacts.ts
@@ -159,6 +159,7 @@ export async function uploadDebugArtifacts(
   }
 
   try {
+    // NB: Once `@actions/artifact@v2` is supported on GHES, we can remove usage of `artifact-legacy`.
     if (ghVariant === GitHubVariant.GHES) {
       await artifactLegacy.create().uploadArtifact(
         sanitizeArifactName(`${artifactName}${suffix}`),

diff --git a/src/start-proxy-action-post.ts b/src/start-proxy-action-post.ts
@@ -39,6 +39,7 @@ async function runWrapper() {
       return;
     }
     try {
+      // NB: Once `@actions/artifact@v2` is supported on GHES, we can remove usage of `artifact-legacy`.
       if (config.gitHubVersion.type === GitHubVariant.GHES) {
         await artifactLegacy
           .create()