Bazel-build for C# language pack #16519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criemen
added
the
depends on internal PR
criemen
force-pushed
the
criemen/bazel-csharp
branch
from
8e396a2
to
0289be0
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This commits a bazel-based build system for C# using `rules_dotnet`. External dependencies are managed via `paket`, and updates to the generated bazel files are done via `./update-deps.sh`. We're providing our own (minimal) test runner for `xunit` tests.
GitInfo doesn't work with the bazel-based build. Instead, we pull in the information from bazel, which correctly works with the bazel cache.
criemen
force-pushed
the
criemen/bazel-csharp
branch
from
0289be0
to
731b941
Compare
criemen
changed the title
tamasvajk
reviewed
May 21, 2024
redsun82
reviewed
May 21, 2024
redsun82
reviewed
May 21, 2024
Bazel/C#: avoid zipmerge
tamasvajk
reviewed
May 22, 2024
tamasvajk
reviewed
May 22, 2024
tamasvajk
previously approved these changes
May 24, 2024
redsun82
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits a bazel-based build system for C# using
rules_dotnet. External dependencies are managed viapaket, and updates to the generated bazel files are done via./update-deps.sh. We're providing our own (minimal) test runner forxunittests.
I'll follow up with an internal PR that updates the documentation on how to update dependencies.