Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update managing-scheduled-reminders-for-your-team.md with "Get mentioned on slack" section #31801

Merged
merged 8 commits into from
May 31, 2024
Merged

Update managing-scheduled-reminders-for-your-team.md with "Get mentioned on slack" section #31801

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9013c71
Update managing-scheduled-reminders-for-your-team.md
ranyitz Feb 23, 2024
873c0c4
Update managing-scheduled-reminders-for-your-team.md
felicitymay May 31, 2024
9b5cfca
Update slack-channel.md
felicitymay May 31, 2024
ca6db71
Update managing-scheduled-reminders-for-your-organization.md
felicitymay May 31, 2024
ccdbf7c
Update slack-channel.md for feedback
felicitymay May 31, 2024
8f98b13
Merge branch 'main' into patch-1
felicitymay May 31, 2024
9f41dfa
Update data/reusables/reminders/slack-channel.md
felicitymay May 31, 2024
53ad9ab
Merge branch 'main' into patch-1
ranyitz May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ing-organization-settings/managing-scheduled-reminders-for-your-organization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,6 @@ Organization owners can schedule a reminder for one or more teams in their organ

## Further reading

- [Getting started](https://github.com/integrations/slack?tab=readme-ov-file#getting-started) in the Slack integrations documentation
- "[AUTOTITLE](/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-your-membership-in-organizations/managing-your-scheduled-reminders)"
- "[AUTOTITLE](/organizations/organizing-members-into-teams/managing-scheduled-reminders-for-your-team)"
1 change: 1 addition & 0 deletions ...ons/organizing-members-into-teams/managing-scheduled-reminders-for-your-team.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,5 +69,6 @@ Team maintainers and organization owners can set scheduled reminders for any pul

## Further reading

- [Getting started](https://github.com/integrations/slack?tab=readme-ov-file#getting-started) in the Slack integrations documentation
- "[AUTOTITLE](/organizations/managing-organization-settings/managing-scheduled-reminders-for-your-organization)"
- "[AUTOTITLE](/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-your-membership-in-organizations/managing-your-scheduled-reminders)"
2 changes: 2 additions & 0 deletions data/reusables/reminders/slack-channel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
1. Under "Slack channel", type the name of the Slack channel where you'd like to receive notifications.
> [!TIP]
> If this Slack channel is private, you will need to invite the integration into the channel: `/invite @github`. Alternatively, you can ask users to run `/github signin` in the Slack channel. For more information, see [Getting started](https://github.com/integrations/slack?tab=readme-ov-file#getting-started) in the Slack integrations documentation.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me correct it (to the best of my knowledge)

  1. Using /invite @github to a private channel is mandatory for the integration to work.
  2. Running /github signin is not an alternative to running /invite @github, in fact the integration works and send reminders without it. Running /github signin for each users will allow them to get tagged as part of the reminder.

The last part about tagging of users is the missing part that need to be somewhere in the docs. Please see my original version of the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When saying tagging I meant, mention. So the user gets a notification and as a result, aware that they need to review a PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your clear review comments. I've updated the tip.

Loading