Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code scanning alerts re: workflows permissions #3289

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Sep 2, 2024

  • add permissions to stale workflow
  • add permissions to tests workflow
  • remove empty brackets on pull_request branch in tests workflow
  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


- [x] add permissions to stale workflow
- [x] add permissions to tests workflow
  - [x] remove empty brackers on pull_request branch in tests workflow

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth self-assigned this Sep 2, 2024
@jmeridth jmeridth requested a review from a team as a code owner September 2, 2024 16:32
@A1811-qbite

This comment was marked as spam.

@Farahnady

This comment was marked as spam.

Jhonsshons

This comment was marked as spam.

@jmeridth
Copy link
Member Author

jmeridth commented Sep 4, 2024

@github/communities-oss-reviewers bump 😄

Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jmeridth jmeridth added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 28af371 Sep 4, 2024
7 checks passed
@jmeridth jmeridth deleted the jm_fix_code_scan_alerts_workflow_permissions branch September 4, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants