WIP: Add Azure DevOps integration #20202
Draft
+2,896
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
reviewed
Sep 16, 2024
| @@ -14,20 +14,27 @@ type CreateAuthProviderArgs = { | |||
| clientId: string; | |||
| clientSecret: string; | |||
| userId: string; | |||
| authorizationUrl?: string; | |||
| tokenUrl?: string; | |||
There was a problem hiding this comment.
Some (minimal) comment on what those fields are would be 🏅
geropl
reviewed
Sep 16, 2024
| export type Status = "pending" | "verified"; | ||
| export interface OAuth2CustomConfig { |
There was a problem hiding this comment.
Or maybe here would be a better place for those comments.
Although, now that I see the name of the shape, it's 95% self-explanatory 😆
geropl
reviewed
Sep 16, 2024
| @@ -14,7 +14,7 @@ plugins: | |||
| - module=github.com/gitpod-io/gitpod/components/public-api/go | |||
| - name: protoc-proxy-gen | |||
| out: go | |||
| path: /workspace/go/bin/protoc-proxy-gen | |||
| path: /root/go-packages/bin/protoc-proxy-gen | |||
There was a problem hiding this comment.
This is different between next and now config IIRC. We should align that in the image. 😬
|
Awesome work @mustard-mh ! 🧡 |
| @@ -337,6 +385,9 @@ const RedirectUrlDescription: FunctionComponent<RedirectUrlDescriptionProps> = ( | |||
| case AuthProviderType.BITBUCKET_SERVER: | |||
| docsUrl = "https://www.gitpod.io/docs/configure/authentication/bitbucket-server"; | |||
| break; | |||
| case AuthProviderType.AZURE_DEVOPS: | |||
| docsUrl = "https://www.gitpod.io/docs/configure/authentication/azure-devops"; | |||
Description
Related Issue(s)
Fixes ENT-552
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold