Skip to content
This repository has been archived by the owner on Oct 11, 2021. It is now read-only.

Crash if tap on a card just after the release scroll. #37

Open
VinayMaheshwari opened this issue Aug 3, 2016 · 11 comments
Open

Crash if tap on a card just after the release scroll. #37

VinayMaheshwari opened this issue Aug 3, 2016 · 11 comments
Assignees
@gleue
Labels
bug

Comments

@VinayMaheshwari
Copy link

Tap on a card to see exposed view. Scroll up down (Pan gesture) in a way the [self.collectionView cancelInteractiveTransition]; been called from handleCollapsePanGesture: case UIGestureRecognizerStateEnded. Just a that movement tap on the exposed card. App crashes with the below logs.

2016-08-03 19:25:03.766 TGLStackedViewExample[358:20875] -[TGLStackedLayout setTransitionProgress:]: unrecognized selector sent to instance 0x125f176f0
2016-08-03 19:25:03.768 TGLStackedViewExample[358:20875] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[TGLStackedLayout setTransitionProgress:]: unrecognized selector sent to instance 0x125f176f0'
*** First throw call stack:
(0x180b76db0 0x1801dbf80 0x180b7dc4c 0x180b7abec 0x180a78c5c 0x18651d538 0x18651dfe8 0x185f436d0 0x185f43434 0x18154d038 0x180b2d794 0x180b2d438 0x180b2ab4c 0x180a54c50 0x18233c088 0x185d3e088 0x10008390c 0x1805f28b8)
libc++abi.dylib: terminating with uncaught exception of type NSException
@VinayMaheshwari VinayMaheshwari changed the title Crash if tap on a card just after the relaese scroll. Crash if tap on a card just after the release scroll. Aug 3, 2016
@VinayMaheshwari
Copy link
Author

NOTE: I have disabled the MoveGesture. Because I don't need the rearrange feature.
//[self.collectionView addGestureRecognizer:self.moveGestureRecognizer];

@carlmknott
Copy link

Yes, I get the same problem. Any ideas? PS This project is AWESOME.

@gleue
Copy link
Owner

gleue commented Aug 27, 2016

Sorry for not responding -- been on vacation. Will be back to my desk on monday ;)

@gleue gleue self-assigned this Aug 29, 2016
@gleue gleue added the bug label Aug 29, 2016
gleue added a commit that referenced this issue Aug 29, 2016
@gleue
Fixed issue #37: View controller no longer crahses when trying to sel…
8b8c542 
…ect item immediately after end of interactive collapse gesture

* Keeping track of interactive transition state in internal property [TGLStackedViewController -interactiveTransitionInProgress]
* Selection is disabled as long as interactive transition is not yet completed
* Fixed cleaning up static variables at the end of interactive transition
@gleue gleue closed this as completed Aug 29, 2016
@VinayMaheshwari
Copy link
Author

I am still able to reproduce the crash.

Device logs:

Aug 31 13:14:25 iPhone SpringBoard[58] : SecTrustEvaluate [leaf IssuerCommonName SubjectCommonName]
Aug 31 13:14:25 iPhone SpringBoard[58] : SecTrustEvaluate [leaf IssuerCommonName SubjectCommonName]
Aug 31 13:14:25 iPhone kernel[0] : xpcproxy[4250] Container: /private/var/mobile/Containers/Data/Application/49C479C5-1298-401E-8243-C161E3ADFD7B (sandbox)
Aug 31 13:14:25 iPhone com.apple.xpc.launchd[1] : assertion failed: 13F69: launchd + 116796 [9F6284CF-8A17-36CC-9DB5-85D510A21F14]: 0x3
Aug 31 13:14:25 iPhone SpringBoard[58] : LICreateIconForImage passed NULL CGImageRef image
Aug 31 13:15:07 iPhone TGLStackedViewExample[4250] : -[TGLStackedLayout setTransitionProgress:]: unrecognized selector sent to instance 0x1266ac2a0
Aug 31 13:15:07 iPhone TGLStackedViewExample[4250] : *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[TGLStackedLayout setTransitionProgress:]: unrecognized selector sent to instance 0x1266ac2a0'
*** First throw call stack:
(0x18145edb0 0x180ac3f80 0x181465c4c 0x181462bec 0x181360c5c 0x186e05538 0x186e05fe8 0x18682b6d0 0x18682b434 0x181e35038 0x181415794 0x181415438 0x181412b4c 0x18133cc50 0x182c24088 0x186626088 0x1000bb83c 0x180eda8b8)
Aug 31 13:15:07 iPhone SpringBoard[58] : HW kbd: Failed to set (null) as keyboard focus
Aug 31 13:15:07 iPhone com.apple.xpc.launchd1 : Service exited due to signal: Abort trap: 6
Aug 31 13:15:07 iPhone diagnosticd[85] : unable to find offset 0x80ecf98c in shared cache for arch 'arm64'
Aug 31 13:15:07 iPhone ReportCrash[4251] : platform_thread_get_unique_id matched 1201426
Aug 31 13:15:07 iPhone ReportCrash[4251] : Formulating report for corpse[4250] TGLStackedViewExample
Aug 31 13:15:07 iPhone ReportCrash[4251] : Saved type '109(109_TGLStackedViewExample)' report (2 of max 25) at /var/mobile/Library/Logs/CrashReporter/TGLStackedViewExample-2016-08-31-131507.ips
Aug 31 13:15:07 iPhone SpringBoard[58] : Application 'UIKitApplication:com.gleue-interactive.TGLStackedViewExample[0xaf05]' crashed.
Aug 31 13:15:07 iPhone UserEventAgent[26] : 8738172920852: id=com.gleue-interactive.TGLStackedViewExample pid=4250, state=0
Aug 31 13:15:07 iPhone searchd[155] : ====^^^^ DuetExpert missing data, count -> people:0 applicationDeepLinks:0 applications:8 requests:158 missingAllDataRequests:0
Aug 31 13:15:39 iPhone syncdefaultsd[4252] : (Note ) SYDAccount: no account
Aug 31 13:15:39 iPhone syncdefaultsd[4252] : (Note ) SYDBootAccount: no account (null)
Aug 31 13:15:39 iPhone syncdefaultsd[4252] : (Note ) SYDPIMAccount: no account (null)
Aug 31 13:15:39 iPhone syncdefaultsd[4252] : (Note ) SYDAlwaysOnAccount: no account (null)

NOTE: In code i just comment out
// [self.collectionView addGestureRecognizer:self.moveGestureRecognizer];
because I do not want the move gesture.

Attached the video (Please ignore -Audio) to show how to reproduce crash.
IMG_0209.MOV.zip

@VinayMaheshwari
Copy link
Author

As per my understanding with your recent changes "addition of interactiveTransitionInProgress flag" not allowing selection of card while Transition In Progress.
But it may be case of cancelInteractiveTransition.

@gleue
Copy link
Owner

gleue commented Aug 31, 2016

Ok, I had to try hard as in your video, but I could reproduce the crash. I'll have to investigate further, I guess

@gleue gleue reopened this Aug 31, 2016
gleue added a commit that referenced this issue Sep 8, 2016
@gleue
Fixed layout transitions
c0a36ef 
* During animated layout changes touch events are ignored globally
* Interactive collapsing transition should no longer crash when cards are tapped (Issue #37)
@gleue
Copy link
Owner

gleue commented Sep 8, 2016

Could you please test again w/ release 2.1.2?

@VinayMaheshwari
Copy link
Author

Sure, I will update you by Monday. Thank you.

@gleue
Copy link
Owner

gleue commented Oct 1, 2016

Fixed another bug regarding interactive transitions in 2.1.3

@gleue gleue closed this as completed Oct 1, 2016
@abdultcb
Copy link

Thanks buddy.

@decim92
Copy link

decim92 commented Oct 14, 2018

This should be open, I'm having the same crash constantly in version 2.2

@gleue gleue reopened this Oct 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gleue gleue

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gleue @decim92 @abdultcb @VinayMaheshwari @carlmknott