Support subsystem #103
Closed
Support subsystem #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibuler
commented
Apr 28, 2019
| } | ||
| return | ||
| } | ||
| // If change the \n to \r\n, then zmodem(rzsz) will be error |
There was a problem hiding this comment.
If do that replace, zmodem sz will be error
|
Request preview or discuss |
Open
|
or maybe here? This subsystem implementation look quite good. |
fix panic bug when not found any subsystem
|
What is needed to merge this? |
|
Thanks for submitting this! Recently subsystem support was merged in #111, so hopefully that will work for you! I realize there are some oddities which end up rewriting part of the stream, so hopefully something can be submitted to fix that in a more comprehensive way. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Subsystem support added, see examples
#63
#101