Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds EffectsManager #1310

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adds EffectsManager #1310

wants to merge 2 commits into from

Commits on May 22, 2021

  1. Makes modifiers and didCreate/didUpdate cache driven

    This PR finishes up the autotracking refactors that were done
    previously, making after-render effects that used to be handled by the
    render transaction handled instead by an EffectsManager. The
    EffectsManager essentially manages a number of caches, which it keeps
    in lists internally. Every time a render completes, these queues are
    scheduled to run, with every cache in the queue being checked in order
    to see if something has changed. If it has, the effect runs its update.
    
    The biggest change with this refactor is that the
    `didCreate`/`didUpdate` hooks used by classic components will now
    interleave with modifiers. Previously, they always ran _before_ all
    modifiers, regardless of whether the modifiers were children of a given
    component. In theory, this shouldn't be an issue, but if it is we can
    separate out the component hooks into a separate queue and restore the
    prevous ordering.
    Chris Garrett committed May 22, 2021
    Configuration menu
    Copy the full SHA
    5a5d0d9 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2021

  1. try reference

    Chris Garrett committed May 23, 2021
    Configuration menu
    Copy the full SHA
    ecef385 View commit details
    Browse the repository at this point in the history