Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Adapt URL of gnosis safe to unified version #1863

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Nov 16, 2021

Summary

Closes #1849
Adapts to the new URL structure for gnosis Safe after the unification deployed today

image

Now URLs look like this:
https://gnosis-safe.io/app/rin:0x951D3d754abdB5182815e3E43d55eD3433b52522/transactions/history

To Test

  1. Links to the Gnosis Safe for the tree networks

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@anxolin anxolin marked this pull request as ready for review November 16, 2021 18:33
@anxolin anxolin requested review from a team November 16, 2021 18:34
Copy link

@MareenG MareenG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It currently links to the Safe transaction queue but shouldn't it link to the transaction history?

@elena-zh
Copy link

@MareenG , safe URL does not have a separation between 'queue' and 'history' tabs, so it is impossible to navigate exactly to the history.
https://us02web.zoom.us/j/87568027224?pwd=MEdyeThTRWtnL01aMWZrRjF1NmRjdz09
The only thing we can do is to suggest Gnosis Safe team to separate these URLs to

  • /transactions#queue
  • /transactions#history

And then we will be able to redirect directly to the History.

@MareenG
Copy link

MareenG commented Nov 17, 2021

@MareenG , safe URL does not have a separation between 'queue' and 'history' tabs, so it is impossible to navigate exactly to the history. https://us02web.zoom.us/j/87568027224?pwd=MEdyeThTRWtnL01aMWZrRjF1NmRjdz09 The only thing we can do is to suggest Gnosis Safe team to separate these URLs to

  • /transactions#queue
  • /transactions#history

And then we will be able to redirect directly to the History.

But when you click on the link Anxo provided it directs you to the history.
https://gnosis-safe.io/app/rin:0x951D3d754abdB5182815e3E43d55eD3433b52522/transactions/history
Whereas the link in the PR directs you to the queue
https://gnosis-safe.io/app/rin:0x6EB8Ee3c042606dae355fCD4f9370C28f019Fb19/transactions/queue

@elena-zh
Copy link

elena-zh commented Nov 17, 2021

@MareenG , got it, thank you! I have a previous version installed to my PC and did not notice that they had already changes routes.
Sorry about that

@anxolin
Copy link
Contributor Author

anxolin commented Nov 17, 2021

@MareenG I send to the queue on porpouse.

This will change once they implement 5afe/safe-react#970

I have to choose queue or history, i choose queue because is more relevant to me to send the users to sign while the tx needs more signatures than seeing it in the history

@anxolin
Copy link
Contributor Author

anxolin commented Nov 17, 2021

Guys, i will need to merge this to mege in Barn. I address comments if u have more

@elena-zh
Copy link

I would suggest to separate cases when we may navigate users to the /queue or the /history pages.
I have created a separate issue for this #1877

@anxolin
Copy link
Contributor Author

anxolin commented Nov 18, 2021

I would suggest to separate cases when we may navigate users to the /queue or the /history pages.
I have created a separate issue for this #1877

Yes is a good point. I will do as separate PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants