Skip to content

Commit

Permalink
Back out changeset 4c378dd47cf2
Browse files Browse the repository at this point in the history
* libgui/src/command-widget.cc (console::console): The new syntax doesn't work
on Window. Add a comment why the old syntax is used for these connections.
  • Loading branch information
mmuetzel committed Jun 17, 2024
1 parent 8689007 commit b4d71a3
Showing 1 changed file with 10 additions and 6 deletions.
16 changes: 10 additions & 6 deletions libgui/src/command-widget.cc
Original file line number Diff line number Diff line change
Expand Up @@ -355,14 +355,18 @@ console::console (command_widget *p)
setMargins (0);
setWrapMode (QsciScintilla::WrapWord);

connect (this, &QsciScintilla::cursorPositionChanged,
this, &console::cursor_position_changed);
// The following three signal-slot connections must use the old syntax or
// they would fail to connect on Windows with warnings like this:
// qt.core.qobject.connect: QObject::connect: signal not found in octave::console

connect (this, &QsciScintilla::textChanged,
this, &console::text_changed);
connect (this, SIGNAL (cursorPositionChanged (int, int)),
this, SLOT (cursor_position_changed (int, int)));

connect (this, &QsciScintilla::modificationAttempted,
this, &console::move_cursor_to_end);
connect (this, SIGNAL (textChanged ()),
this, SLOT (text_changed ()));

connect (this, SIGNAL (modificationAttempted ()),
this, SLOT (move_cursor_to_end ()));

console_lexer *lexer = new console_lexer ();
setLexer (lexer);
Expand Down

0 comments on commit b4d71a3

Please sign in to comment.