Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "provide a better panic message when no jobs in scheduler and start blocking called" #503

Merged
merged 1 commit into from
May 30, 2023

Conversation

JohnRoesler
Copy link
Contributor

Reverts #501

There are cases where it can be called and not cause a deadlock, so I'm just going to leave it alone for now.

example:

package main

import (
	"log"
	"time"

	"github.com/go-co-op/gocron"
)

func main() {
	go func() {
		for {
			time.Sleep(time.Second)
			log.Println("doing something")
		}
	}()

	s := gocron.NewScheduler(time.UTC)
	s.StartBlocking()
}

@JohnRoesler JohnRoesler merged commit 604aa9b into main May 30, 2023
@JohnRoesler JohnRoesler deleted the revert-501-better-panic-message branch May 30, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant