Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid allocations with (*regexp.Regexp).MatchString #602

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Avoid allocations with (*regexp.Regexp).MatchString #602

merged 1 commit into from
Oct 29, 2023

Commits on Oct 29, 2023

  1. Avoid allocations with (*regexp.Regexp).MatchString 

    We should use `(*regexp.Regexp).MatchString` instead of
`(*regexp.Regexp).Match([]byte(...))` when matching string to avoid
unnecessary `[]byte` conversions and reduce allocations.

Example benchmark:

func BenchmarkMatch(b *testing.B) {
	for i := 0; i < b.N; i++ {
		if match := timeWithSeconds.Match([]byte("06:18:01")); !match {
			b.Fail()
		}
	}
}

func BenchmarkMatchString(b *testing.B) {
	for i := 0; i < b.N; i++ {
		if match := timeWithSeconds.MatchString("06:18:01"); !match {
			b.Fail()
		}
	}
}

goos: linux
goarch: amd64
pkg: github.com/go-co-op/gocron
cpu: AMD Ryzen 7 PRO 4750U with Radeon Graphics
BenchmarkMatch-16          	 7213512	       223.8 ns/op	       8 B/op	       1 allocs/op
BenchmarkMatchString-16    	 8484169	       145.8 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	github.com/go-co-op/gocron	4.114s

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
    @Juneezee
    Juneezee committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    e72ec14 View commit details
    Browse the repository at this point in the history