bind vars generation failed when use both WHERE + IN and HAVING.

[sio4]

If I use something like WHERE id in (?) and HAVING count(id) = ? at the same time, it does not compiled expectedly.

The line below is called if there is in (?) on SQL which is built by buildSelectSQL(), but there is another ? for HAVING and sqlx.In() returns error "number of bindVars exceeds arguments". (I cannot sure since I just checked it on pop code and did not get into sqlx code anyway.)

pop/sql_builder.go

Line 59 in 8d249c6

s, _, err := sqlx.In(sq.sql, sq.Args())

IMHO, we can move this lines into buildWhereClauses(). Can I open a PR for this?

[markbates]

There's a PR already for this issue, #67, should be merged today or tomorrow.

[stanislas-m]

Fixed with #67.

[sio4]

Nice, it works well!