Improved the "in" support #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislas-m
requested changes
Apr 17, 2018
| } | ||
| } | ||
| csql := string(out) | ||
| csql := sqlx.Rebind(sqlx.DOLLAR, sql) |
There was a problem hiding this comment.
You might want to do the same for the cockroach driver, since it's a Postgres-compatible DB.
mclark4386
reviewed
Apr 17, 2018
query.go
Outdated
| } | ||
| qs := fmt.Sprintf("(%s)", strings.Join(inq, ",")) | ||
| stmt = strings.Replace(stmt, "(?)", qs, 1) | ||
| stmt = strings.Replace(stmt, "(?)", qs, 1) |
There was a problem hiding this comment.
Why are you doing this line twice?
There was a problem hiding this comment.
@mclark4386 cause I liked it so much! ;) accidental vim at it's best.
|
@stanislas-m fixed, can you look again when you have a chance? thanks. |
stanislas-m
approved these changes
Apr 18, 2018
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.