Bump go versions #226
Merged
Bump go versions #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislas-m
requested changes
Aug 27, 2018
.travis.yml
Outdated
| @@ -5,9 +5,8 @@ dist: trusty | |||
| sudo: required | |||
|
|
|||
| go: | |||
| - 1.8 | |||
| - 1.9 | |||
There was a problem hiding this comment.
Buffalo's next version will support Go 1.9, so we can't drop it now: gobuffalo/buffalo#1106
There was a problem hiding this comment.
Despite go 1.9 being past its EOL now?
There was a problem hiding this comment.
Yes. You can open an issue in the buffalo repo if you think we should reconsider it, but from the time being Buffalo will target 1.9+ on the next version.
There was a problem hiding this comment.
Btw., I've updated the commit yesterday to re-include 1.9
stanislas-m
previously approved these changes
Aug 28, 2018
|
Sorry, I wasn't my intention to dismiss the review. I did not realize that PRs should be opened against the |
stanislas-m
approved these changes
Aug 29, 2018
|
@michael-k Np, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.