Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed TruncateAll bug from CockroachDB dialect with database version 19.1.1 #386

Closed
wants to merge 1 commit into from
Closed

Fixed TruncateAll bug from CockroachDB dialect with database version 19.1.1 #386

wants to merge 1 commit into from

Conversation

jani123
Copy link
Contributor

@jani123 jani123 commented May 30, 2019

Especially problematic on running tests if using same fixture data in multiple tests.

@jani123 jani123 requested a review from a team as a code owner May 30, 2019 06:48
mclark4386
mclark4386 approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@mclark4386 mclark4386 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Thanks for the code and tests!

@mclark4386 mclark4386 changed the base branch from master to development May 31, 2019 09:23
@mclark4386 mclark4386 changed the base branch from development to master May 31, 2019 09:23
mclark4386
mclark4386 suggested changes May 31, 2019
View reviewed changes
Copy link
Member

@mclark4386 mclark4386 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Need to PR against the development branch, not master.

@jani123 jani123 changed the base branch from master to development May 31, 2019 10:15
@jani123 jani123 changed the base branch from development to master May 31, 2019 10:16
@jani123
Copy link
Contributor Author

jani123 commented May 31, 2019

Oops! Need to PR against the development branch, not master.

Oh, yes, will do :)

@jani123 jani123 mentioned this pull request May 31, 2019
Merged
@jani123
Copy link
Contributor Author

jani123 commented May 31, 2019

replaced by #387

@jani123 jani123 closed this May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mclark4386 mclark4386 mclark4386 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jani123 @mclark4386