Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration table name option #60

Merged
merged 5 commits into from
Apr 16, 2018
Merged

Add migration table name option #60

merged 5 commits into from
Apr 16, 2018

Conversation

nawaitesidah
Copy link
Contributor

Enables changing the default migration table name ("schema_migrations")

@markbates
Copy link
Member

@hadigoh looks good, there some merge conflicts. if you could clean those up, that would be great. thanks.

Copy link
Member

@markbates markbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve merge conflicts

@nawaitesidah
Copy link
Contributor Author

Thanks @stanislas-m for resolving the conflicts 👍

@stanislas-m
Copy link
Member

@hadigoh Np. :)

@stanislas-m stanislas-m dismissed markbates’s stale review April 14, 2018 10:57

Conflicts solved. :)

Copy link
Member

@markbates markbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! If you could add a quick bit of docs to the README.md this can be merged. Thanks.

Copy link
Member

@markbates markbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to update the README with this new feature.

@nawaitesidah
Copy link
Contributor Author

I've added the readme to include an example to this feature 👍

@markbates markbates merged commit 6bd7630 into gobuffalo:master Apr 16, 2018
@markbates
Copy link
Member

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants