Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #49: disable MySQL foreign keys on truncate all #88

Merged
merged 4 commits into from
May 14, 2018
Merged

Fix #49: disable MySQL foreign keys on truncate all #88

merged 4 commits into from
May 14, 2018

Conversation

stanislas-m
Copy link
Member

  • Use SET SESSION FOREIGN_KEY_CHECKS to disable / enable fks.
  • Fix MySQL truncation list to exclude views.

@stanislas-m
Fix #49: disable MySQL foreign keys on truncate all
68a4180 
* Use SET SESSION FOREIGN_KEY_CHECKS to disable / enable fks.
* Fix MySQL truncation list to exclude views.
@stanislas-m
Exclude SQLite3 for the add_foreign_key migration
9247095
@stanislas-m
Remove foreign key, that's a side-issue
2839701
@stanislas-m
Copy link
Member Author

@u007 Since you asked in #85 to have a word on the PRs, can you take a look at this one when you have some time? :)

@u007
Copy link
Member

u007 commented May 11, 2018 •
edited
Loading

@stanislas-m thank you for getting me involve, glad to be :)
ya i think it looks good, that is a useful fix :)

@stanislas-m stanislas-m added this to the v4.5.9 milestone May 14, 2018
@markbates markbates merged commit bdc00fb into master May 14, 2018
@stanislas-m stanislas-m deleted the task/fix-mysql-truncate-all-with-fk branch May 18, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markbates markbates markbates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.5.9
Development

Successfully merging this pull request may close these issues.
3 participants
@stanislas-m @u007 @markbates