Generate boilerplate or no code deploy common contracts #77 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmank88 thoughts? |
treeder
requested changes
Mar 6, 2019
There was a problem hiding this comment.
Please use openzeppelin contacts, and preferably pull them directly from their repo. Better yet do the same as this: https://medium.com/gochain/the-easiest-way-to-deploy-an-openzeppelin-smart-contract-no-truffle-required-d248d4c3835a
The only thing to generate is that gist.
|
To expand on that, like the blog post, this should probably do the git clone part of that and things to setup the users environment to make mods and do what they want with other openzeppelin features if they want. |
|
@treeder updated, could you take a look |
jmank88
reviewed
Mar 7, 2019
jmank88
reviewed
Mar 7, 2019
jmank88
reviewed
Mar 7, 2019
jmank88
reviewed
Mar 7, 2019
jmank88
reviewed
Mar 7, 2019
jmank88
reviewed
Mar 7, 2019
jmank88
reviewed
Mar 7, 2019
treeder
approved these changes
Mar 12, 2019
…mals configurable
jmank88
approved these changes
Mar 12, 2019
treeder
approved these changes
Mar 13, 2019
r-gochain
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #77