Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importer doesn't drop -col and -colonly suffixes in animation tracks, but removes them from node names #42041

Closed
seadra opened this issue Sep 14, 2020 · 1 comment · Fixed by #43044

Comments

@seadra
Copy link

seadra commented Sep 14, 2020

When importing any .dae or .gltf file exported using Blender's (2.90) built-in exporters, the animations don't work for -col/-colonly objects,

The reason appears to be quite simple: the importer drops the -col and -colonly suffix from the node names, but the animation tracks are referring to (non-existing) nodes with -col and -colonly suffix.

(Side note: when exporting gltf with Blender 2.90, "Group by NLA track" needs to be checked off, otherwise, only one of the existing tracks appear in theAnimationPlayer node, possibly a separate issue for gltf importer)

@seadra
Copy link
Author

seadra commented Sep 15, 2020

I think the node names can be fixed in this loop. At first glance, it seems one can use _fixstr() on the path, but it actually only works for a single node name. It also requires a specific suffix.

I current don't have time to work on this, but a few possible ways I see this can be fixed:

  • A generalization of _fixstr() that works for a full path, and scans for all possible suffixes could be made & used?
  • It is possible to avoid renames that drop suffixes, that would fix the problem
  • Keep track of all _fixstr() changes in a hashmap, and do the animation renaming using that hashmap after all renames are completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants