Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D Onion skinning not working #52412

Closed
butkeim opened this issue Sep 5, 2021 · 0 comments · Fixed by #52667
Closed

3D Onion skinning not working #52412

butkeim opened this issue Sep 5, 2021 · 0 comments · Fixed by #52667

Comments

@butkeim
Copy link
Contributor

butkeim commented Sep 5, 2021

Godot version

3.3.stable

System information

Windows 10

Issue description

Onion skinning is not working for 3D scene.

I did a bit of investigation on my side and suspect this pull #22225 to be reason of the bug, we can see under animation_player_editor_plugin.cpp that the split of forward_draw_over_viewport() function is partially implemented, only the canvas function is present, the spatial one being missing.

This is only an intuition, I did not do any test/deep research.

pinging @RandomShaper as discussed, as he is the one responsible for the implementation of onion skinning.

Steps to reproduce

This can easily be reproduce, following next steps :

  • Create a MeshInstance in a Spatial scene.
  • Create an AnimationPlayer.
  • Create a track modifying, for example, MeshInstance's position.
  • Activate Onion skinning
  • Play the current animation, see that onion skinning is not working

Minimal reproduction project

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants