Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix 3D Onion skinning missing #52664

Merged
merged 1 commit into from
Sep 14, 2021
Merged

[3.x] Fix 3D Onion skinning missing #52664

merged 1 commit into from
Sep 14, 2021

Conversation

butkeim
Copy link
Contributor

@butkeim butkeim commented Sep 14, 2021

Fixes #52412

3D Onion skinning was missing since #22225

AnimationPlayerEditorPlugin::forward_spatial_force_draw_over_viewport implementation was missing.

I renamed AnimationPlayerEditor::forward_canvas_force_draw_over_viewport to forward_force_draw_over_viewport for coherency.

I think I should do a PR for the master branch also, can someone confirm? (this is my first PR, sry if it's clunky)

Bugsquad edit: 3.x version of #52667.

@akien-mga akien-mga requested review from RandomShaper and a team September 14, 2021 12:03
@akien-mga akien-mga added this to the 3.4 milestone Sep 14, 2021
@akien-mga akien-mga changed the title Fix 3D Onion skinning missing [3.x] Fix 3D Onion skinning missing Sep 14, 2021
@akien-mga
Copy link
Member

I think I should do a PR for the master branch also, can someone confirm?

Indeed, a PR for the master branch would also be needed to make sure that this is solved in 4.0 and all future releases.

@akien-mga akien-mga merged commit 07d7754 into godotengine:3.x Sep 14, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants