Fix transparent editor theme being brighter #36004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanfranke
force-pushed
the
fix-transparent-theme-color
branch
from
1efae74
to
4faaa4d
Compare
|
Updated to new master branch. Should work completely fine but additional testing may be needed |
nathanfranke
force-pushed
the
fix-transparent-theme-color
branch
from
4faaa4d
to
797c97e
Compare
nathanfranke
force-pushed
the
fix-transparent-theme-color
branch
from
797c97e
to
0222f78
Compare
Calinou
approved these changes
Mar 20, 2021
Calinou
added
the
cherrypick:3.x
|
Thanks! |
|
Cherry-picked for 3.3. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIL that you can have a transparent editor theme, but it makes the editor background also transparent, and the background before that is white. This update forces the background alpha to be opaque
Before
After
