Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Fix Area monitorable in 2D and 3D Godot physics. #41699

Merged
merged 1 commit into from
Nov 20, 2021
Merged

[3.x] Fix Area monitorable in 2D and 3D Godot physics. #41699

merged 1 commit into from
Nov 20, 2021

Conversation

madmiraal
Copy link
Contributor

3.2 version of #41698.

@madmiraal madmiraal added this to the 3.2 milestone Sep 2, 2020
@capnm
Copy link
Contributor

capnm commented Sep 19, 2020 •
edited
Loading

I can confirm, fixes #23484 #41698 in 3.2 👍

@capnm capnm mentioned this pull request Sep 23, 2020
Closed
@madmiraal madmiraal requested a review from a team as a code owner March 12, 2021 12:26
Base automatically changed from 3.2 to 3.x March 16, 2021 11:11
@akien-mga akien-mga modified the milestones: 3.2, 3.3 Mar 17, 2021
@akien-mga akien-mga changed the title [3.2] Fix Area monitorable in 2D and 3D Godot physics. [3.x] Fix Area monitorable in 2D and 3D Godot physics. Mar 26, 2021
@akien-mga akien-mga modified the milestones: 3.3, 3.4 Mar 26, 2021
@Chaosus Chaosus modified the milestones: 3.4, 3.5 Nov 8, 2021
@pouleyKetchoupp
Copy link
Contributor

Same as #41698, should be good but needs a rebase.

@madmiraal
Add area to moved list when changing monitorable,
e900bac 
and only remove area from query when deleting pair if it was monitorable.
@akien-mga akien-mga merged commit 2493995 into godotengine:3.x Nov 20, 2021
@akien-mga
Copy link
Member

Thanks!

@madmiraal madmiraal deleted the fix-23484-3.2 branch November 20, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:physics
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
5 participants
@madmiraal @capnm @pouleyKetchoupp @akien-mga @Chaosus