[3.2] Improve rotation gizmo #43016
Merged
[3.2] Improve rotation gizmo #43016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
enhancement
feature proposal
topic:editor
usability
and removed
feature proposal
labels
Hide the back sides of the rotation gizmo circles and add a white outline for better visualization of the rotation "sphere". This is a 3.2 backport of @JFonS work on the master branch; all credit goes to him.
mbrlabs
force-pushed
the
rotation-gizmo-32
branch
from
1c842e2
to
69b99ba
Compare
|
Hm, the iOS export templates failed to build. It worked before my force-push and this PR touches editor-only files. Looks like a caching problem in the CI server, so a clean build would probably fix it. |
JFonS
approved these changes
Oct 28, 2020
|
Maybe since they get compiled when clicking on a Spatial for the first time. But it's not really noticable and this "lazy-compiling" of shaders happens quite a lot inside the editor. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we probably going to have to wait quite a while for Godot 4.0, i backported the improved rotation gizmo added in #42094 to 3.2. I think this is a huge usability improvement and should be included in 3.2.
All credit goes to @JFonS for this amazing work.
It was a pretty straightforward port. I basically just had to update the renamed classes/methods and change the render mode
depth_test_disabledtodepth_test_disablein the shaders.