Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow input echo when changing ui focus #44456

Merged
merged 1 commit into from
Apr 8, 2021
Merged

allow input echo when changing ui focus #44456

merged 1 commit into from
Apr 8, 2021

Conversation

univeous
Copy link
Contributor

It will allow us to change UI focus continuously by holding navigation key.

before:
ftqMlL9Dlw

after:
nAKWXeiieE

It's a more common UI pattern. In Godot editor itself it works like the latter.

Discussion

Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The input->is_action_pressed("ui_focus_next") part is no longer necessary, as it's already checked in the event (or at least I don't see any difference after removing it).

Also this needs rebase.

@univeous
Copy link
Contributor Author

Is it looks ok now?

@akien-mga
Copy link
Member

@univeous FYI, the email used to sign your commit (see header of https://patch-diff.githubusercontent.com/raw/godotengine/godot/pull/44456.patch ) doesn't seem to be linked to your GitHub account. That's not a problem for Git nor for us, but if you want to get full attribution for this commit, you can add this email as secondary email in your GitHub settings.

@univeous
Copy link
Contributor Author

univeous commented Apr 8, 2021

@univeous FYI, the email used to sign your commit (see header of https://patch-diff.githubusercontent.com/raw/godotengine/godot/pull/44456.patch ) doesn't seem to be linked to your GitHub account. That's not a problem for Git nor for us, but if you want to get full attribution for this commit, you can add this email as secondary email in your GitHub settings.

not noticed before. Added. thank you!

@akien-mga akien-mga merged commit 0283bc8 into godotengine:master Apr 8, 2021
@akien-mga
Copy link
Member

Thanks!

@univeous univeous deleted the allow_input_echo_in_ui_focus branch April 9, 2021 11:52
@akien-mga
Copy link
Member

Cherry-picked for 3.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants