Add AudioEffectCapture #45593
Merged
Add AudioEffectCapture #45593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduz
approved these changes
Jan 30, 2021
akien-mga
reviewed
Jan 31, 2021
lyuma
force-pushed
the
audio_effect_capture
branch
from
0fdad5c
to
04def33
Compare
akien-mga
reviewed
Feb 2, 2021
akien-mga
reviewed
Feb 2, 2021
akien-mga
reviewed
Feb 2, 2021
akien-mga
reviewed
Feb 2, 2021
akien-mga
reviewed
Feb 2, 2021
lyuma
force-pushed
the
audio_effect_capture
branch
from
04def33
to
d1bf46e
Compare
akien-mga
reviewed
Feb 2, 2021
doc/classes/AudioEffectCapture.xml
Outdated
| <return type="int"> | ||
| </return> | ||
| <description> | ||
| Returns the number of frames available to read using [method get_buffer] |
There was a problem hiding this comment.
Suggested change
| Returns the number of frames available to read using [method get_buffer] | |
| Returns the number of frames available to read using [method get_buffer]. |
akien-mga
reviewed
Feb 2, 2021
doc/classes/AudioEffectCapture.xml
Outdated
| <return type="PackedVector2Array"> | ||
| </return> | ||
| <argument index="0" name="frames" type="int"> | ||
| Number of audio frames to return. |
There was a problem hiding this comment.
Arguments can't be documented this way, running doctool would remove it. Argument-specific details can be given in the <description> (though here I think the description is clear enough about what [code]frames[/code] is).
akien-mga
approved these changes
Feb 2, 2021
AudioEffectCapture allows access to the microphone and other audio on an audio bus in real-time. Co-Authored-By: K. S. Ernest (iFire) Lee <ernest.lee@chibifire.com>
lyuma
force-pushed
the
audio_effect_capture
branch
from
d1bf46e
to
d800329
Compare
|
Thanks! |
|
Hi. Great news! Will this be available in 3.2? |
3.2.4 is still in release candidate stage, so it's up to Remi if new functionality can still be added. Anyway, I filed pull request #46304 |
|
Why doesn't this support signals, and instead require every user to poll? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AudioEffectCapture allows access to the microphone and other audio on an audio bus in real-time.
Implementation of the updated proposal at godotengine/godot-proposals#2013
Thanks to @fire and @Faless for their input and help.
Bugsquad edit:
Fixes: godotengine/godot-proposals#2013, godotengine/godot-proposals#399, #35402