[3.2] Add support for new SDL gamecontroller keywords.

[madmiraal]

3.2 version of #45797.

Note: This breaks compat, because it changes the value of JOY_BUTTON_MAX from 16 to 22. This, for example, will break Joypads Demo which uses it here.

The non-compat breaking alternative is to hardcode ignoring these new keywords as was done in #44062 with hint entries.

Personally, I think the benefit of providing support for these buttons outweighs the potential issues existing projects will have with dealing with the change in the enum reflecting the number of buttons supported.

[akien-mga]

Note: This breaks compat, because it changes the value of JOY_BUTTON_MAX from 16 to 22. This, for example, will break Joypads Demo which uses it here.

I think it's OK to change the value if we're indeed adding support for more buttons, but I'm a bit wary about the impact this may have on GDNative compiled binaries? CC @vnen @BastiaanOlij

[BastiaanOlij]

@akien-mga I don't think it will pose problems, GDNative doesn't interact directly with the structure but just with calls. It just won't know the max is increased unless you create a new api.json file but the calls to get the values will work just fine.

Note that in Godot 4 we've updated the maximum to 36, might want to do the same here instead of 22 if we're changing it anyway?

This will however break the joypad test app in our demo repo as it loops through all buttons and updates the UI but won't have 22 buttons to update. I think that demo should be made a little more resilient :) edit ah this was already noted in the OP :)

[akien-mga]

Thanks!