Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust auto scale on 4k monitors to 150% #45910

Merged
merged 1 commit into from
Feb 14, 2021

Conversation

Ansraer
Copy link
Contributor

@Ansraer Ansraer commented Feb 11, 2021

Right now the automatic editor scale is either 100% or 200%, depending on resolution and dpi. While this works fine on smaller screens (e.g. laptops) it can cause issues on larger screens.
As discussed with @Calinou on rocketchat this PR aims to add a middle ground (150%) between 100% and 200% for larger hidpi displays.

EDIT: Not sure if you are still cherry-picking stuff for 3.2, but in theory, it should be possible to use this as is.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to apply the suggestion to the two other places in the code.

editor/editor_node.cpp Outdated Show resolved Hide resolved
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:editor usability labels Feb 11, 2021
@Calinou Calinou added this to the 4.0 milestone Feb 11, 2021
@Ansraer
Copy link
Contributor Author

Ansraer commented Feb 11, 2021

Make sure to apply the suggestion to the two other places in the code.

I am fairly certain I already apply this change to all 3 places. Where would I find two more?

@Ansraer Ansraer force-pushed the default-scale-highres-monitor branch from 79ab949 to 4373a34 Compare February 11, 2021 23:51
@Ansraer Ansraer changed the title Adjust auto scale on 4k monitors to 125% Adjust auto scale on 4k monitors to 150% Feb 11, 2021
@Calinou
Copy link
Member

Calinou commented Feb 12, 2021

I am fairly certain I already apply this change to all 3 places. Where would I find two more?

By "two other places", I meant the ones you already modified in the diff 🙂

@akien-mga akien-mga merged commit b21f854 into godotengine:master Feb 14, 2021
@akien-mga
Copy link
Member

Thanks!

@Ansraer Ansraer deleted the default-scale-highres-monitor branch February 14, 2021 13:34
@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants