Expose editor scale to the plugin API #47622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
added
enhancement
topic:editor
topic:plugin
cherrypick:3.x
RandomShaper
approved these changes
Apr 5, 2021
Calinou
requested changes
Apr 5, 2021
YuriSizov
force-pushed
the
editor-plugins-expose-scale
branch
from
ea57c47
to
ea31af6
Compare
Calinou
approved these changes
Apr 5, 2021
|
Thanks! |
|
Cherry-picked for 3.3. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from plugin developers it seems that it's a requirement to have access to the actual scale value to make consistent and good looking plugin UI. While it is possible to read the setting, when it's set to
Autovalues are calculated internally in a way that is not accessible to the scripting API. This exposes a method that gives direct access to readingEDSCALEvalue.It's a method and not a property because, AFAIK, we cannot do readonly properties currently and setting this value is definitely not something that can be exposed either.