[Net] Implement String::parse_url for parsing URLs. #48205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Apr 26, 2021
| @@ -240,6 +240,70 @@ String String::word_wrap(int p_chars_per_line) const { | |||
| return ret; | |||
| } | |||
|
|
|||
| Error String::parse_url(String &r_scheme, String &r_host, int &r_port, String &r_path) const { | |||
There was a problem hiding this comment.
Might be worth adding a short description similar to what you put in the PR, since it's not exposed and thus documented in the classref.
Faless
force-pushed
the
net/4.x_url_parsing
branch
from
b0e994a
to
3bb4066
Compare
Splits the URL into (scheme, host, port, path). Supports both literal IPv4 and IPv6. Strip credentials when present (e.g. http://user:pass@example.com/). Use that function in both HTTPRequest and WebSocketClient.
akien-mga
approved these changes
Apr 26, 2021
akien-mga
added
cherrypick:3.3
cherrypick:3.x
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits the URL into (scheme, host, port, path).
Supports both literal IPv4 and IPv6.
Strip credentials when present (e.g. http://user:pass@example.com/).
Use that function in both HTTPRequest and WebSocketClient.
Fixes #39331
Fixes #43365