Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable setting of collision iterations in PhysicsServer2D #48827

Merged
merged 1 commit into from
May 19, 2021
Merged

Enable setting of collision iterations in PhysicsServer2D #48827

merged 1 commit into from
May 19, 2021

Conversation

Rhathe
Copy link
Contributor

@Rhathe Rhathe commented May 19, 2021

master version of #38387

@Rhathe Rhathe requested review from a team as code owners May 19, 2021 06:30
@Rhathe Rhathe mentioned this pull request May 19, 2021
Merged
@pouleyKetchoupp pouleyKetchoupp added this to the 4.0 milestone May 19, 2021
@Rhathe
Enable setting of collision iterations in PhysicsServer2D
88b1802 
This allows fine-tuning of collision iterations for more
accurate collision physics with a performance cost.
pouleyKetchoupp
pouleyKetchoupp suggested changes May 19, 2021
View reviewed changes
Copy link
Contributor

@pouleyKetchoupp pouleyKetchoupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one thing to fix in order to pass checks, otherwise it looks fine.

servers/physics_2d/physics_server_2d_sw.h Outdated Show resolved Hide resolved
@akien-mga akien-mga merged commit 896d84b into godotengine:master May 19, 2021
@akien-mga
Copy link
Member

Thanks!

@Rhathe Rhathe deleted the set_iterations_master branch May 20, 2021 01:01
This was referenced Jul 7, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pouleyKetchoupp pouleyKetchoupp pouleyKetchoupp approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:physics topic:2d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Rhathe @akien-mga @pouleyKetchoupp