Fail gracefully when a mesh fails to import. #48912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
cherrypick:3.3
cherrypick:3.x
akien-mga
approved these changes
May 21, 2021
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.3.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a mesh instance is processed that triggers an error in
_process_mesh_instances, it causes the function to abort early and leaves many meshes with unassigned skeletons or skins.This patch uses
ERR_CONTINUE_MSGinstead ofERR_FAIL_CONDwithin the for loop.Here are some valid glTF meshes which trigger errors at present in Godot (PRs pending):
DirectParentedSkeletons.glb
NestedSkeletonReproCaseV2Animated.glb
While I recognize that this patch is handling a failure case that ideally would never hapen, the point is it allows for maintaining consistent behavior even when there are bugs or invalid gltf nodes. Leaving ERR_FAIL here will cause a sort of undefined behavior (for example, skinned meshes arbitrarily not parented to their skeletons).
Worked with @fire on debugging this