Fix incorrect skin deduplication when using named binds #48913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
bug
cherrypick:3.3
cherrypick:3.x
akien-mga
approved these changes
May 21, 2021
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.3.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the number of instances in which this particular "
_skins_are_same" optimization will take place. It should be safe.Solves one of the bugs triggered by this case: NestedSkeletonReproCaseV2Animated.glb
In this case, two nodes are referencing the same mesh, but with a different skin... but the skin has the same IBP matrices, and only differs in bone names (the bone indices are -1 because Use Named Binds is enabled by default.
This bug is also present in 3.x and should be backported. Worked on this with @fire