Tweak pressed CheckBox appearance in the editor #48954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the accent color to match pressed CheckButtons after they were updated. Checked checkboxes are now more prominent in the user's peripheral vision, which can be useful at times. This also matches how checkboxes look in most operating systems and web browsers.
Calinou
added
the
cherrypick:3.x
YeldhamDev
approved these changes
May 22, 2021
|
This looks good for project/editor settings where your focus is fully on editing the settings, but I wonder if this wouldn't be too much accent for boolean properties in the inspector. I guess we can merge and see if users complain. |
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #22150.
This uses the accent color to match pressed CheckButtons after they were updated. I got the idea thanks to this mockup 🙂
Checked checkboxes are now more prominent in the user's peripheral vision, which can be useful at times. This also matches how checkboxes look in most operating systems and web browsers.
Note that this has the same limitations as the previous CheckButton PR (non-default accent colors won't be used to recolor the icon). I still think this is an usability upgrade overall, so we can look into adding recoloring support for icons later in the 4.0 cycle.
This is cherry-pickable to the
3.xbranch for consistency with the aforementioned CheckButton PR. The change also "makes sense" without the editor theme revamp, so it should be visually consistent there.Preview
Dark theme
Light theme