Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Makes shader 'TIME' available in custom functions by default #49509

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Jun 11, 2021

Backport of #37166 (with #37167, #37171 fixes) to 3.x branch.
I tested it with all shader modes: GLES3/GLES2 & Spatial/CanvasItem/Particles

GIF

time_3 x

I made a fixing change to scene.glsl (GLES3) to make it properly handle time in custom functions of Spatial shader (it was declared after the declaration of custom functions and cannot be handled otherwise).

@Chaosus Chaosus requested a review from a team as a code owner June 11, 2021 12:07
@Chaosus Chaosus added this to the 3.4 milestone Jun 11, 2021
@Chaosus Chaosus requested a review from clayjohn June 11, 2021 12:10
@Chaosus Chaosus force-pushed the shader_time_3.x branch 2 times, most recently from 0c544d1 to 90e93ae Compare June 11, 2021 12:18
@akien-mga akien-mga merged commit 51dd4d0 into godotengine:3.x Aug 16, 2021
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the shader_time_3.x branch August 16, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants