Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GridMap erasing octants in the wrong order #50052

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Fix GridMap erasing octants in the wrong order #50052

merged 1 commit into from
Jul 1, 2021

Conversation

Valeryn4
Copy link
Contributor

@Valeryn4 Valeryn4 commented Jul 1, 2021 •
edited by pouleyKetchoupp
Loading

Fix GridMap problem issues: #33648, #43712 and #49995

Bugsquad edit: fixes #33648, fixes #43712, fixes #49995

@Valeryn4 Valeryn4 requested a review from a team as a code owner July 1, 2021 17:28
@Valeryn4 Valeryn4 mentioned this pull request Jul 1, 2021
Closed
@pouleyKetchoupp pouleyKetchoupp added bug cherrypick:3.3 cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:3d topic:core labels Jul 1, 2021
@pouleyKetchoupp pouleyKetchoupp added this to the 4.0 milestone Jul 1, 2021
@pouleyKetchoupp pouleyKetchoupp linked an issue Jul 1, 2021 that may be closed by this pull request
The GridMap freezes if meshes are changed frequently #49995
Closed
pouleyKetchoupp
pouleyKetchoupp approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@pouleyKetchoupp pouleyKetchoupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks!

@Valeryn4
Copy link
Contributor Author

Valeryn4 commented Jul 1, 2021

I don't like the abundant use of List in the code.
memory allocation occurs too often.

@akien-mga akien-mga changed the title Fix GridMap erase Octans Fix GridMap erasing octants in the wrong order Jul 1, 2021
@akien-mga akien-mga merged commit 382ddd4 into godotengine:master Jul 1, 2021
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jul 5, 2021
@akien-mga
Copy link
Member

Cherry-picked for 3.3.3.

@Valeryn4 Valeryn4 deleted the Valeryn4-Fix-GridMap branch July 6, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pouleyKetchoupp pouleyKetchoupp pouleyKetchoupp approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:core topic:3d
Projects
None yet
Milestone
4.0
3 participants
@Valeryn4 @akien-mga @pouleyKetchoupp