[HTML5] Raise default initial memory to 32 MiB. #50422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The memory was resized in any case during start. Mitigate Chromium issue: https://bugs.chromium.org/p/v8/issues/detail?id=11863 Also fix a warning about SAFE_HEAP being a linker only flag.
Faless
added
enhancement
platform:web
topic:buildsystem
cherrypick:3.x
akien-mga
approved these changes
Jul 13, 2021
ghost
reviewed
Jul 13, 2021
| @@ -130,7 +130,6 @@ def configure(env): | |||
| env.Append(CCFLAGS=["-fsanitize=leak"]) | |||
| env.Append(LINKFLAGS=["-fsanitize=leak"]) | |||
| if env["use_safe_heap"]: | |||
| env.Append(CCFLAGS=["-s", "SAFE_HEAP=1"]) | |||
There was a problem hiding this comment.
See comment: Also fix a warning about SAFE_HEAP being a linker only flag.
https://github.com/emscripten-core/emscripten/blob/main/src/settings.js#L306
There was a problem hiding this comment.
Do you have a source which can verify that warning? I don't want it to bite back later.
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memory was resized in any case during start.
Mitigate Chromium issue (#49797):
https://bugs.chromium.org/p/v8/issues/detail?id=11863
Also fix a warning about SAFE_HEAP being a linker only flag.