-
-
Notifications
You must be signed in to change notification settings - Fork 20.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Add highlight to the relationship lines of selected Tree items #50622
base: 3.x
Are you sure you want to change the base?
[3.x] Add highlight to the relationship lines of selected Tree items #50622
Conversation
19ab4f6
to
84b659e
Compare
I didn't backport it because this PR introduces breaking changes to the theme of the Tree node. I'm not sure if we would allow it for 3.4 or not. As for the other issue, it depends on how close you've copied the implementation. And if you've ported the code from the current master, then it already includes all the fixes 🙃 |
Is there some way to add a compatibility property? I'm guessing not... anyways the release policy says:
I'm not sure, but I'd probably classify this as a minor compatibility breakage in very specific area.
No, I just |
84b659e
to
0eb3f15
Compare
It is possible that there were some changes to the Tree that made it not render the stuff far outside of the visible bound, but yeah, I would still port the most actual code. It would work in 3.x just as well.
It's possible to somehow always fallback on the old property that exists in 3.x if none of the new are set to be above 0. |
0eb3f15
to
1316daa
Compare
Okay, I backported #49085 (I |
71cb8d3
to
c58391c
Compare
Backport of #48546 and #49085
2021-07-19_15-50-42_Trim.mp4