Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Expose visual script custom node type hints #50705

Conversation

Gallilus
Copy link
Contributor

@Gallilus Gallilus commented Jul 21, 2021

Expose the minimal of new virtual methods to give the Node creator all tools needed to create full type hints for input and output ports.

Improves the default guess_output_type() for VisualScriptCustomNode class.

Fixes issues/2692
3.x Version of #48972
Redo of #48900

PS: I hope to get this in 3.3.3 so I don't have to wait ?months before charring plugins

@Gallilus Gallilus requested a review from a team as a code owner July 21, 2021 15:32
@Gallilus Gallilus force-pushed the Expose-visual-script-custom-node-type-hints branch from 90c9436 to 86f6e60 Compare July 21, 2021 17:16
@Gallilus Gallilus force-pushed the Expose-visual-script-custom-node-type-hints branch from 86f6e60 to 9178e24 Compare July 21, 2021 17:34
@Calinou Calinou added this to the 3.4 milestone Jul 22, 2021
@akien-mga akien-mga merged commit 8341c09 into godotengine:3.x Jul 22, 2021
@akien-mga
Copy link
Member

Thanks!

@Gallilus Gallilus deleted the Expose-visual-script-custom-node-type-hints branch July 24, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants