Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore paths with invalid chars in PathWhich #50918

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

raulsntos
Copy link
Member

Fixes #39432

@raulsntos raulsntos requested a review from a team as a code owner July 27, 2021 01:15
Copy link
Contributor

@neikeq neikeq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need code style fixes.

modules/mono/editor/GodotTools/GodotTools/Utils/OS.cs Outdated Show resolved Hide resolved
modules/mono/editor/GodotTools/GodotTools/Utils/OS.cs Outdated Show resolved Hide resolved
@neikeq neikeq merged commit 8ff29d1 into godotengine:master Jul 27, 2021
@neikeq
Copy link
Contributor

neikeq commented Jul 27, 2021

Thanks!

@neikeq neikeq added bug cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:editor topic:dotnet labels Jul 27, 2021
@neikeq neikeq added this to the 4.0 milestone Jul 27, 2021
@raulsntos raulsntos deleted the fix-39432 branch July 27, 2021 09:45
@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jul 27, 2021
@akien-mga
Copy link
Member

Cherry-picked for 3.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modules/mono/mono_gd/gd_mono_utils.cpp:371 - System.ArgumentException: Illegal characters in path.
3 participants