[3.x] Complain if casting a freed object in a debug session #51095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That fails building in non |
RandomShaper
force-pushed
the
error_cast_freed_object_3.x
branch
from
17591a4
to
4661bee
Compare
The idea is to give the user a chance to realize a mistake that will cause a crash in a release build (or with no debugger attached).
RandomShaper
force-pushed
the
error_cast_freed_object_3.x
branch
from
4661bee
to
123d3ef
Compare
akien-mga
approved these changes
Sep 14, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of #51094 for 3.x.
In this version I've needed to add
Variant::get_object_instance_id(), which is the 3.x incarnation of 4.0'sVariant::operator ObjectID(). In 3.x we can't have an operator like that becauseObjectIDis not a proper class but an alias of a primitive type.