Performance improvements for GLES2 CPU blendshapes #51363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
approved these changes
Aug 16, 2021
|
Could you squash the commits? |
|
@akien-mga There! |
|
Thanks! |
This was referenced Feb 14, 2022
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement of my GLES2 CPU blendshape implementation. (#48480)
Instead of calculating the shape buffer data every frame, it only does so when the blend values change, leading to much better idle performance. However, converting the vertex data is still somewhat slow, which becomes apparent when frequently changing the blend shape values. But at the very least it should happen outside of the rendering function.