Use a Big Sur-style macOS icon for the Godot editor #52043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a more coherent visual look with the rest of macOS. Co-authored-by: Hazar <36481442+hazarek@users.noreply.github.com>
Calinou
added
cherrypick:3.x
|
Icon is overeiden during startup. Changing one in the bundle template won't fully change app icon, see #48685 for the relevant code (disables icon override), or the same code can be changed to use macOS specific icon. |
|
It works successfully following the merge of #48685:
|
bruvzg
approved these changes
Sep 30, 2021
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a more coherent visual look with the rest of macOS.
This closes godotengine/godot-proposals#1616.
Thanks @hazarek for providing the icon 🙂
Preview
I don't have a macOS setup at hand right now, so here's Gwenview rendering it for now: