Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkButton's text now is automatically translated in 3.x #52138

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

LeaoLuciano
Copy link
Contributor

@LeaoLuciano LeaoLuciano commented Aug 26, 2021

Fix #52120
Contributors: @Lucas3H

Bugsquad edit: 3.x version of #52145.

@LeaoLuciano LeaoLuciano requested a review from a team as a code owner August 26, 2021 21:39
@Calinou Calinou added this to the 4.0 milestone Aug 26, 2021
@YeldhamDev YeldhamDev merged commit ac33441 into godotengine:3.x Aug 26, 2021
@YeldhamDev YeldhamDev modified the milestones: 4.0, 3.4 Aug 26, 2021
@KoBeWi
Copy link
Member

KoBeWi commented Aug 26, 2021

What about the master branch fix? The PR wasn't merged there.

@YeldhamDev
Copy link
Member

@KoBeWi Aren't we discussing to flat out remove LinkButton on 4.0? I thought it would be wasted effort.

@KoBeWi
Copy link
Member

KoBeWi commented Aug 26, 2021

It's not like it's decided already. The changes would be almost the same, so the PR could've been opened for master and then cherry-picked. But well, now that it's merged, master fix can wait.

@akien-mga
Copy link
Member

Cherry-picked for 3.3.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants