LSP: Add support for custom host setting #52330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
previously requested changes
Sep 1, 2021
|
@Calinou I'm unsure if the changes went through, do I need to make these changes in my personal fork branch? |
Calinou
reviewed
Sep 2, 2021
vnen
previously requested changes
Sep 10, 2021
There was a problem hiding this comment.
Needs a small fix, otherwise looks good. Also needs to squash all the commits (see the documentation for info about this).
| port = (int)_EDITOR_GET("network/language_server/remote_port"); | ||
| use_thread = (bool)_EDITOR_GET("network/language_server/use_thread"); | ||
| if (protocol.start(port, IPAddress("127.0.0.1")) == OK) { | ||
| if (protocol.start(port, IP_Address(host)) == OK) { |
There was a problem hiding this comment.
It seems you are using an outdated version, this was renamed to IPAddress (without underscore) a while ago.
Suggested change
| if (protocol.start(port, IP_Address(host)) == OK) { | |
| if (protocol.start(port, IPAddress(host)) == OK) { |
You can now configure host in the `language_server` settings in the editor settings.
akien-mga
force-pushed
the
add_support_hostname_language_server
branch
from
ec7a08a
to
be6da39
Compare
|
Force pushed a rebase to squash commits and fix the build issue. |
akien-mga
added
the
cherrypick:3.x
akien-mga
changed the title
akien-mga
approved these changes
Sep 20, 2021
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now set host in the language_server settings in the editor settings. I am also making a pull request to make changes to the VSCode godot-tools to be able to set the language_server host as well.
This allows you to connect to the godot language_server when using WSL2 and docker.
This is a link to the pull request in the vscode plugin
godotengine/godot-vscode-plugin#297