[3.x] Backport Accept global classes for MainLoop type in project settings
#52438
Conversation
tommyZZM
force-pushed
the
main-loop-type-class-3.x
branch
from
2029a89
to
f2a3af4
Compare
| } else { // Not based on script path. | ||
| if (!editor && !ClassDB::class_exists(main_loop_type) && ScriptServer::is_global_class(main_loop_type)) { | ||
| String script_path = ScriptServer::get_global_class_path(main_loop_type); | ||
| Ref<Script> script_res = ResourceLoader::load(script_path, "Script", true); |
There was a problem hiding this comment.
- Ref<Script> script_res = ResourceLoader::load(script_path);
+ Ref<Script> script_res = ResourceLoader::load(script_path, "Script", true);
script_res should be load without any cache
There was a problem hiding this comment.
I think this shouldn't matter much because not a lot of resources get loaded at engine startup to worry about this I guess.
There was a problem hiding this comment.
most of the time, the loading of custom main loop is fine.
some times. if I clike Run Button very fast after opening the editor. then my custom main loop script seems load failed.
After this error happening, script wont be reload until I reopen the editor.
tested by setting no_cache=true here still won't fix this problem.
There was a problem hiding this comment.
I think this feature may just reveal editor problem. According to error, the base type is basically "", which probably means that editor settings could not get loaded (maybe when the file gets locked for reading, and cannot be read again until the previous Godot process shuts down completely).
|
Thanks! |
This PR backports the feature that acceptting global classes for
MainLooptype in project settings, introduced in #41190 on master.