[3.x] Refactor event handlers, drop most emscripten html5 dependencies. #52812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faless
force-pushed
the
js/3.x_our_input
branch
from
6a099ea
to
d11a768
Compare
Faless
force-pushed
the
js/3.x_our_input
branch
from
d11a768
to
6d239f8
Compare
This makes us more independent from emscripten libraries, giving us more control on the application lifecycle.
Removes more emscripten HTML5 library dependencies.
Removes more emscripten HTML5 library dependencies.
Removes more emscripten HTML5 library dependencies.
I don't think anyone is actively using it, and it's a lot of convoluted code.
Faless
force-pushed
the
js/3.x_our_input
branch
from
6d239f8
to
adef4ed
Compare
akien-mga
approved these changes
Oct 5, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
canvasPolicy == 2, i.e. default).In an effort to be less dependent on emscripten libraries, this PR drops most of the
emscripten_*function usage in favour of internal JS implementations. This gives us more control over input processing, there's more work that could be done on this (e.g. resuming the AudioContext directly from JS), but this PR is growing already quite big, so I'd rather do that in a separate one.With this, the only emscripten functions left used from C++ are the app lifecycle functions (set/cancel main loop, exit) and webgl related functions (context creation, buffer swapping, GLES compatibility).
3.xversion of: #52811