Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix rendering centered odd-size texture in AnimatedSprite/AnimatedSprite3D #53052

Merged

Conversation

kleonc
Copy link
Member

@kleonc kleonc commented Sep 25, 2021

3.x version of #53051.
Cherry-pickable 3.3?

@kleonc kleonc requested review from a team as code owners September 25, 2021 10:28
@kleonc kleonc changed the title Fix rendering centered odd-size texture in AnimatedSprite/AnimatedSprite3D [3.x] Fix rendering centered odd-size texture in AnimatedSprite/AnimatedSprite3D Sep 25, 2021
@Calinou Calinou added this to the 3.4 milestone Sep 25, 2021
@lawnjelly
Copy link
Member

lawnjelly commented Oct 2, 2021

This does look like a good fix. Gawd knows if it will cause something knock on (often we end up having a second bit of code dependent on the first bug... 😁 ) but it seems worth trying out.

@kleonc kleonc force-pushed the animated-sprites-centered-rendering-3x branch from eea1a55 to e2e149f Compare October 3, 2021 12:16
@akien-mga akien-mga merged commit 58fe0bd into godotengine:3.x Oct 5, 2021
@akien-mga
Copy link
Member

Thanks!

@kleonc kleonc deleted the animated-sprites-centered-rendering-3x branch October 5, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants