Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Faster hash_compare for integer and string keys in dictionaries #53557

Merged

Conversation

Listwon
Copy link
Contributor

@Listwon Listwon commented Oct 8, 2021

3.x version of #53555

Enums are handled as dictionaries under the hood in 3.x, so it not only boosts their performance as keys in dictionaries but also makes them faster in general. Related issue (not fixed by this PR): #53315

@Listwon Listwon requested a review from a team as a code owner October 8, 2021 08:32
@Chaosus Chaosus added this to the 3.5 milestone Oct 8, 2021
@akien-mga akien-mga modified the milestones: 3.5, 3.4 Oct 8, 2021
@akien-mga akien-mga merged commit b280da0 into godotengine:3.x Oct 8, 2021
@akien-mga
Copy link
Member

Thanks!

@Listwon Listwon deleted the faster-string-int-dictionary-3x branch February 9, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants